[all-commits] [llvm/llvm-project] 998f24: [libc++][test] Fixes for `hash<Emplaceable>` and v...

A. Jiang via All-commits all-commits at lists.llvm.org
Mon Feb 10 15:57:15 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 998f2422a563bb85065bfd1633d10644d9af3f92
      https://github.com/llvm/llvm-project/commit/998f2422a563bb85065bfd1633d10644d9af3f92
  Author: A. Jiang <de34 at live.cn>
  Date:   2025-02-11 (Tue, 11 Feb 2025)

  Changed paths:
    M libcxx/test/std/containers/Emplaceable.h
    M libcxx/test/std/containers/container.adaptors/flat.map/flat.map.access/at_transparent.pass.cpp

  Log Message:
  -----------
  [libc++][test] Fixes for `hash<Emplaceable>` and value discarding (#126566)

Currently `std::hash<Emplaceable>::operator()` relies implicit
conversion from `int` to `size_t`, which makes MSVC compelling. This PR
switches to use `static_cast`.

In `flat.map/flat.map.access/at_transparent.pass.cpp`, there's one
value-discarding use of `at` that wasn't marked `TEST_IGNORE_NODISCARD`.
This PR adds the missing `TEST_IGNORE_NODISCARD`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list