[all-commits] [llvm/llvm-project] 04d551: [mlir][cmake] Add missing MLIRTestDialect dependen...

Diego Caballero via All-commits all-commits at lists.llvm.org
Mon Feb 10 13:26:32 PST 2025


  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 04d55131ce724ad4a8ca2686ee54df83484f94e9
      https://github.com/llvm/llvm-project/commit/04d55131ce724ad4a8ca2686ee54df83484f94e9
  Author: Diego Caballero <dieg0ca6aller0 at gmail.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M mlir/test/lib/Pass/CMakeLists.txt

  Log Message:
  -----------
  [mlir][cmake] Add missing MLIRTestDialect dependencies

This cherry picks
[mlir] Fix build race condition in Pass Manager tests (d906da5ead2764579395e5006c517f2ec9afd46f)
to the 20.x release branch.

This addresses issues that started with
https://github.com/llvm/llvm-project/pull/123910, which is already on the 20.x branch.

Linaro noticed this on our flang dylib (shared library) build bot.

In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

We have tested these changes on the buildbot for the last 2 days and had no problems.
Whereas before it was failing maybe 1 in 10 builds, enough that multiple people
in the community noticed it.

Reported in https://github.com/llvm/llvm-project/issues/124485.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list