[all-commits] [llvm/llvm-project] feb30f: [Offload] Fix the offload cache file triggering li...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Feb 10 11:20:59 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: feb30f25c0d40e928496d2bd17dd74c23e993583
      https://github.com/llvm/llvm-project/commit/feb30f25c0d40e928496d2bd17dd74c23e993583
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-02-10 (Mon, 10 Feb 2025)

  Changed paths:
    M offload/cmake/caches/Offload.cmake

  Log Message:
  -----------
  [Offload] Fix the offload cache file triggering libc++ / libstdc++ mixing (#126313)

Summary:
We originally wanted `-stdlib=libc++` by default so that it could use
offloading support in libc++, however this causes issues with out the
Offloading proejct itself is built. Is the user builds the LLVM libs
with libstdc++ then uses this cache it will enable this option by
default for the ensuing build of the offloading libraries with the newly
build clang. This will cause a lot of linker failured because the C++
library doesn't match.

Long term I think the proper solution to this is to make better use of
clang configuration files, but I don't know a good way to do that by
default. For now just make it build right.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list