[all-commits] [llvm/llvm-project] 343bbd: Use a stable sort to handle overlapping/duplicate ...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 343bbda140d5a15cd7d7fbfc6041a7506da5cdae
      https://github.com/llvm/llvm-project/commit/343bbda140d5a15cd7d7fbfc6041a7506da5cdae
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp

  Log Message:
  -----------
  Use a stable sort to handle overlapping/duplicate line sequences

This can occur due to linker ICF and stable sort will ensure the results
are stable.

No explicit/new test coverage, because nondeterminism is non-testable.

It should already be covered by the DWARFDebugLineTest that was failing
some internal testing on an ARM machine which might've been what changed
the sort order. But `llvm::sort` also deliberately randomizes the
contents (under EXPENSIVE_CHECKS) so I'd have expected failures to show
up in any EXPENSIVE_CHECKS Build...



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications