[all-commits] [llvm/llvm-project] bfba62: [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF ...

[Nick Sarnie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bfba6215cec20bee308a4637298a590057004ff8
      https://github.com/llvm/llvm-project/commit/bfba6215cec20bee308a4637298a590057004ff8
  Author: Nick Sarnie <nick.sarnie at intel.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M clang/test/Tooling/clang-linker-wrapper-spirv-elf.cpp
    M clang/test/lit.site.cfg.py.in
    M llvm/utils/gn/secondary/clang/test/BUILD.gn

  Log Message:
  -----------
  [clang-linker-wrapper][lit] Fix OpenMP SPIR-V ELF test again (#126142)

I was able to reproduce the issue with the sanitizer buildbot scripts
and confirmed this fixes it.

The issue was the quotes, `"0"` is true in Python so we incorrectly
added the `spirv-tools` feature even when the CMake variable was false.
I don't know why it didn't always fail.

Also add the var to clang's `BUILD.gn` which matches what we do for
other similar variables, however I don't think it has any effect on CI
here.

Signed-off-by: Sarnie, Nick <nick.sarnie at intel.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications