[all-commits] [llvm/llvm-project] 1608fe: [lldb][Breakpoint] Allow whitespace in breakpoint ...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1608fe8d56015719d5bf7abca608adad8a866f43
      https://github.com/llvm/llvm-project/commit/1608fe8d56015719d5bf7abca608adad8a866f43
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-02-07 (Fri, 07 Feb 2025)

  Changed paths:
    M lldb/source/Interpreter/OptionArgParser.cpp
    A lldb/test/Shell/Commands/command-breakpoint-by-addr.test

  Log Message:
  -----------
  [lldb][Breakpoint] Allow whitespace in breakpoint address expression (#126053)

Setting a breakpoint on `<symbol> + <offset>` used to work until
`2c76e88e9eb284d17cf409851fb01f1d583bb22a`, where this regex was
reworked. Now we only accept `<symbol>+ <offset>` or
`<symbol>+<offset>`.

This patch fixes the regression by adding yet another `[[:space:]]*`
component to the regex.

One could probably simplify the regex (or even replace the regex by just
calling the relevent `consumeXXX` APIs on `llvm::StringRef`). Though I
left that for the future.

rdar://130780342



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications