[all-commits] [llvm/llvm-project] ff049e: [AMDGPU] Do not enable GPU sanitizers by default (...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff049e07a55f03916f18b10cdba1456cd3022b14
      https://github.com/llvm/llvm-project/commit/ff049e07a55f03916f18b10cdba1456cd3022b14
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    M clang/lib/Driver/ToolChains/AMDGPU.cpp
    M clang/test/Driver/hip-sanitize-options.hip

  Log Message:
  -----------
  [AMDGPU] Do not enable GPU sanitizers by default (#126090)

Summary:
This probably wasn't the intended result, but the code here causes
OpenMP to always link in `ockl.bc` which was intentionally not linked.
This results in the OCKL definitions conflicting with the OpenMP ones
and also prevents them from being optimized out (Might be fixed with
newer ROCm that actually builds the visibility correctly).

I'm pretty sure the only reason this didn't break the tests is because
we're smart and pass `-nogpulib` there to keep the environment from
being poisoned with stuff like this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications