[all-commits] [llvm/llvm-project] 5812d0: [Offload] Make only a single thread handle the RPC...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5812d0bf8e920ec9a2f14b60237a07f74a9e7d6b
      https://github.com/llvm/llvm-project/commit/5812d0bf8e920ec9a2f14b60237a07f74a9e7d6b
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    M offload/plugins-nextgen/common/include/RPC.h
    M offload/plugins-nextgen/common/src/PluginInterface.cpp
    M offload/plugins-nextgen/common/src/RPC.cpp

  Log Message:
  -----------
  [Offload] Make only a single thread handle the RPC server thread (#126067)

Summary:
This patch just changes the interface to make starting the thread
multiple times permissable since it will only be done the first time.
Note that this does not refcount it or anything, so it's onto the user
to make sure that they don't shut down the thread before everyone is
done using it. That is the case today because the shutDown portion is
run by a single thread in the destructor phase.

Another question is if we should make this thread truly global state,
because currently it will be private to each plugin instance, so if you
have an AMD and NVIDIA image there will be two, similarly if you have
those inside of a shared library.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications