[all-commits] [llvm/llvm-project] f15404: [clang] [dataflow] use unqualified type for smart ...

Florian Mayer via All-commits all-commits at lists.llvm.org
Wed Feb 5 18:23:20 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1540484ead766b18aeeb2be8b5fc9057ffa8a40
      https://github.com/llvm/llvm-project/commit/f1540484ead766b18aeeb2be8b5fc9057ffa8a40
  Author: Florian Mayer <fmayer at google.com>
  Date:   2025-02-05 (Wed, 05 Feb 2025)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/SmartPointerAccessorCaching.cpp

  Log Message:
  -----------
  [clang] [dataflow] use unqualified type for smart pointer matching (#125958)

one would assume that `getCanonicalTypeUnqualified` returns an
unqualified type, but sadly one would be wrong. the current logic fails
for std::optional as implemented in libcxx, because Star and Arrow types
mismatch in their const qualification.

there are other places in clang that use
getCanonicalTypeUnqualified().getUnqualifiedType().



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list