[all-commits] [llvm/llvm-project] aefa30: [ORC-RT] Add a comment explaining the purpose of t...

[Lang Hames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aefa30e2301f155d4f4737d6f6c55c66eac58b2d
      https://github.com/llvm/llvm-project/commit/aefa30e2301f155d4f4737d6f6c55c66eac58b2d
  Author: Lang Hames <lhames at gmail.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    M compiler-rt/test/orc/TestCases/Darwin/Generic/exceptions.cpp

  Log Message:
  -----------
  [ORC-RT] Add a comment explaining the purpose of this testcase. NFC.


  Commit: 88f55d16c4c247a9eef326961a1445dee3f2e30c
      https://github.com/llvm/llvm-project/commit/88f55d16c4c247a9eef326961a1445dee3f2e30c
  Author: Lang Hames <lhames at gmail.com>
  Date:   2025-02-06 (Thu, 06 Feb 2025)

  Changed paths:
    A compiler-rt/test/orc/TestCases/Darwin/Generic/exceptions-stress-test-tower.cpp
    M llvm/lib/ExecutionEngine/JITLink/CompactUnwindSupport.h

  Log Message:
  -----------
  [ORC] Fix buggy calculation of second-level-page offset in unwind-info.

SecondLevelPageOffset should be incremented by SecondLevelPageSize bytes, not
one byte.

Failure to calculate the offset correctly leads to corrupted unwind-info (and
consequently broken exceptions / unwinding) when more than one second level
page is needed. Since JITLink's unwind support only produces
UNWIND_SECOND_LEVEL_REGULAR-style pages this would trigger for any file
containing more than 511 functions with unwind info. The included test-case
contains 1022 functions (sufficient for both the current format and any
future implementation that supports UNWIND_SECOND_LEVEL_COMPRESSED pages).

Thanks to @edoardo on discord for spotting this bug!


Compare: https://github.com/llvm/llvm-project/compare/cd9795c10b70...88f55d16c4c2

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications