[all-commits] [llvm/llvm-project] 4eab21: [libc] Remove LlvmLibcStackChkFail.Smash test (#12...

[Roland McGrath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4eab2194872d54e2d4496135a277b1610ff33ead
      https://github.com/llvm/llvm-project/commit/4eab2194872d54e2d4496135a277b1610ff33ead
  Author: Roland McGrath <mcgrathr at google.com>
  Date:   2025-02-05 (Wed, 05 Feb 2025)

  Changed paths:
    M libc/test/src/compiler/stack_chk_guard_test.cpp

  Log Message:
  -----------
  [libc] Remove LlvmLibcStackChkFail.Smash test (#125919)

This test was problematic, and also unnecessary.  It's not really
a test of the libc functionality or ABI.  That's already covered
by the LlvmLibcStackChkFail.Death test.  The Smash test was in
fact just testing that the compiler produces the call in the
expected situation.  That's a compiler test, not a libc test.

It's not really feasible to make a test like this both reliable
and safe.  Since it's not something libc needs to test, it's not
worth trying.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications