[all-commits] [llvm/llvm-project] e8d437: [lldb] WatchAddress ignores modify option (#124847)

[Ben Jackson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8d437f827144061d051ecf199d4075bef317285
      https://github.com/llvm/llvm-project/commit/e8d437f827144061d051ecf199d4075bef317285
  Author: Ben Jackson <puremourning at users.noreply.github.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M lldb/source/API/SBTarget.cpp
    A lldb/test/API/python_api/watchpoint/TestWatchpointRead.py
    M lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

  Log Message:
  -----------
  [lldb] WatchAddress ignores modify option (#124847)

The WatchAddress API includes a flag to indicate if watchpoint should be
for read, modify or both. This API uses 2 booleans, but the 'modify'
flag was ignored and WatchAddress unconditionally watched write
(actually modify).

We now only watch for modify when the modify flag is true.

---

The included test fails prior to this patch and succeeds after. That is
previously specifying `False` for `modify` would still stop on _write_,
but after the patch correctly only stops on _read_



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications