[all-commits] [llvm/llvm-project] 9f133b: Test fixups for MSVC.

Charlie Barto via All-commits all-commits at lists.llvm.org
Tue Feb 4 13:36:01 PST 2025


  Branch: refs/heads/users/chbarto/test_msvc_test_fixups
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f133b43d7bde3986e308d221900a1a3f13d735c
      https://github.com/llvm/llvm-project/commit/9f133b43d7bde3986e308d221900a1a3f13d735c
  Author: Charlie Barto <chbarto at microsoft.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/coverage-basic.cpp
    M compiler-rt/test/asan/TestCases/Windows/crash_read_write.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_host.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memcpy.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memset.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_null_deref.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/Windows/global_const_string_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/illegal_instruction.cpp
    M compiler-rt/test/asan/TestCases/Windows/issue64990.cpp
    M compiler-rt/test/asan/TestCases/Windows/msvc/seh.cpp
    R compiler-rt/test/asan/TestCases/Windows/null_deref.cpp
    M compiler-rt/test/asan/TestCases/Windows/null_deref_multiple_dlls.cpp
    M compiler-rt/test/asan/TestCases/Windows/operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/sse_misalignment.cpp
    M compiler-rt/test/asan/TestCases/Windows/stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/Windows/unsymbolized.cpp
    M compiler-rt/test/asan/TestCases/alloca_big_alignment.cpp
    M compiler-rt/test/asan/TestCases/alloca_constant_size.cpp
    M compiler-rt/test/asan/TestCases/alloca_detect_custom_size_.cpp
    M compiler-rt/test/asan/TestCases/alloca_instruments_all_paddings.cpp
    M compiler-rt/test/asan/TestCases/alloca_loop_unpoisoning.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_partial.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_right.cpp
    M compiler-rt/test/asan/TestCases/alloca_safe_access.cpp
    M compiler-rt/test/asan/TestCases/alloca_underflow_left.cpp
    M compiler-rt/test/asan/TestCases/alloca_vla_interact.cpp
    M compiler-rt/test/asan/TestCases/contiguous_container.cpp
    M compiler-rt/test/asan/TestCases/coverage-trace-pc.cpp
    M compiler-rt/test/asan/TestCases/debug_locate.cpp
    M compiler-rt/test/asan/TestCases/debug_stacks.cpp
    M compiler-rt/test/asan/TestCases/deep_tail_call.cpp
    M compiler-rt/test/asan/TestCases/default_ignorelist.cpp
    M compiler-rt/test/asan/TestCases/default_options.cpp
    A compiler-rt/test/asan/TestCases/defines.h
    M compiler-rt/test/asan/TestCases/error_report_callback.cpp
    M compiler-rt/test/asan/TestCases/exitcode.cpp
    M compiler-rt/test/asan/TestCases/force_inline_opt0.cpp
    M compiler-rt/test/asan/TestCases/global-location-nodebug.cpp
    M compiler-rt/test/asan/TestCases/global-underflow.cpp
    M compiler-rt/test/asan/TestCases/halt_on_error-1.c
    M compiler-rt/test/asan/TestCases/heavy_uar_test.cpp
    M compiler-rt/test/asan/TestCases/ignorelist.cpp
    M compiler-rt/test/asan/TestCases/ill.cpp
    M compiler-rt/test/asan/TestCases/initialization-bug.cpp
    M compiler-rt/test/asan/TestCases/inline.cpp
    M compiler-rt/test/asan/TestCases/intercept-rethrow-exception.cpp
    M compiler-rt/test/asan/TestCases/interception_failure_test.cpp
    M compiler-rt/test/asan/TestCases/interface_test.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs-compare-errors.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs-subtract-errors.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs.cpp
    M compiler-rt/test/asan/TestCases/large_func_test.cpp
    M compiler-rt/test/asan/TestCases/null_deref.cpp
    M compiler-rt/test/asan/TestCases/pass-struct-byval.cpp
    M compiler-rt/test/asan/TestCases/report_error_summary.cpp
    M compiler-rt/test/asan/TestCases/speculative_load.cpp
    M compiler-rt/test/asan/TestCases/stack-buffer-overflow-with-position.cpp
    M compiler-rt/test/asan/TestCases/stack-oob-frames.cpp
    M compiler-rt/test/asan/TestCases/strcat-overlap.cpp
    M compiler-rt/test/asan/TestCases/strcpy-overlap.cpp
    M compiler-rt/test/asan/TestCases/strncat-overlap.cpp
    M compiler-rt/test/asan/TestCases/strncpy-overflow.cpp
    M compiler-rt/test/asan/TestCases/strncpy-overlap.cpp
    M compiler-rt/test/asan/TestCases/throw_call_test.cpp
    M compiler-rt/test/asan/TestCases/throw_catch.cpp
    M compiler-rt/test/asan/TestCases/throw_invoke_test.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-capture.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-dtor-order.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-inlined.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-loop-bug.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-loop-removed.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-loop.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-temp.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-temp2.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-types.cpp
    M compiler-rt/test/asan/TestCases/vla_chrome_testcase.cpp
    M compiler-rt/test/asan/TestCases/vla_condition_overflow.cpp
    M compiler-rt/test/asan/TestCases/vla_loop_overfow.cpp
    M compiler-rt/test/asan/TestCases/zero_page_pc.cpp

  Log Message:
  -----------
  Test fixups for MSVC.
add XFAIL/UNSUPPORTED annotations for tests run wtih real MSVC
macroify usages of clang-specific attributes in asan tests


  Commit: fd8dfaa824da3c3c6b39a90395a79bed81313545
      https://github.com/llvm/llvm-project/commit/fd8dfaa824da3c3c6b39a90395a79bed81313545
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memset.cpp
    M compiler-rt/test/asan/lit.cfg.py

  Log Message:
  -----------
  Add substitution for /Oy-/-fno-omit-frame-pointer

This makes the dll_intercept_memset test work with mingw


  Commit: 152871684046fb422b225f963b24eb42fa46dfd0
      https://github.com/llvm/llvm-project/commit/152871684046fb422b225f963b24eb42fa46dfd0
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/issue64990.cpp
    M compiler-rt/test/asan/TestCases/alloca_constant_size.cpp
    M compiler-rt/test/asan/TestCases/ill.cpp
    M compiler-rt/test/asan/TestCases/interception_failure_test.cpp
    M compiler-rt/test/asan/TestCases/zero_page_pc.cpp

  Log Message:
  -----------
  Use #if defined(...) instead of #if ...


  Commit: 7d955eb1fce525c316e5610b0dca7241397fdb8f
      https://github.com/llvm/llvm-project/commit/7d955eb1fce525c316e5610b0dca7241397fdb8f
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/null_deref_multiple_dlls.cpp
    M compiler-rt/test/asan/TestCases/throw_invoke_test.cpp

  Log Message:
  -----------
  Fix a few mangled test files

These were mangled in the process of pulling them out of the msvc fork

- null_deref_multiple_dlls.cpp -- extern "C" { got removed
- throw_invoke_test.cpp -- #include "defines.h" is needed for
  ATTRIBUTE_NOINLINE, this test is unsupported on msvc so this was not
  caught


  Commit: 8f9fa99786fa22992418a9b6e4881fe1b2cba946
      https://github.com/llvm/llvm-project/commit/8f9fa99786fa22992418a9b6e4881fe1b2cba946
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/use-after-scope-loop-bug.cpp

  Log Message:
  -----------
  use -O1 instead of /O1 in use-after-scope-loop-bug

This is compatible with the "real" gnu toolchain


  Commit: 4736450056e73fb5405a404f7e095eae4776ce01
      https://github.com/llvm/llvm-project/commit/4736450056e73fb5405a404f7e095eae4776ce01
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/ill.cpp

  Log Message:
  -----------
  add a comment clarifying arch support in ill.cpp

With real MSVC this test only supports i386


  Commit: 9d8bd6ddf904b9512f3f2d86aa567706082016e3
      https://github.com/llvm/llvm-project/commit/9d8bd6ddf904b9512f3f2d86aa567706082016e3
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/operator_array_new_with_dtor_left_oob.cpp

  Log Message:
  -----------
  operator_array_new_with_dtor_left_oob: turn opt back on

unlike __attribute__((optnone)) MSVC's #pragma optimize("", off)
needs to be turned back on


  Commit: 5bd2b645f38a6444ef5faf94165923e7feab1e9f
      https://github.com/llvm/llvm-project/commit/5bd2b645f38a6444ef5faf94165923e7feab1e9f
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/crash_read_write.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memcpy.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/issue64990.cpp
    M compiler-rt/test/asan/TestCases/Windows/operator_array_new_with_dtor_left_oob.cpp
    M compiler-rt/test/asan/TestCases/Windows/unsymbolized.cpp
    M compiler-rt/test/asan/TestCases/alloca_constant_size.cpp
    M compiler-rt/test/asan/TestCases/alloca_detect_custom_size_.cpp
    M compiler-rt/test/asan/TestCases/alloca_loop_unpoisoning.cpp
    M compiler-rt/test/asan/TestCases/coverage-trace-pc.cpp
    M compiler-rt/test/asan/TestCases/deep_tail_call.cpp
    M compiler-rt/test/asan/TestCases/default_options.cpp
    M compiler-rt/test/asan/TestCases/defines.h
    M compiler-rt/test/asan/TestCases/error_report_callback.cpp
    M compiler-rt/test/asan/TestCases/heavy_uar_test.cpp
    M compiler-rt/test/asan/TestCases/ill.cpp
    M compiler-rt/test/asan/TestCases/interception_failure_test.cpp
    M compiler-rt/test/asan/TestCases/strncpy-overflow.cpp
    M compiler-rt/test/asan/TestCases/throw_catch.cpp
    M compiler-rt/test/asan/TestCases/throw_invoke_test.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-temp.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-temp2.cpp
    M compiler-rt/test/asan/TestCases/vla_chrome_testcase.cpp
    M compiler-rt/test/asan/TestCases/zero_page_pc.cpp

  Log Message:
  -----------
  clang-format everything


  Commit: b6b7d3138bd0c8e1379e737014fea05d7a81fd53
      https://github.com/llvm/llvm-project/commit/b6b7d3138bd0c8e1379e737014fea05d7a81fd53
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_intercept_memset.cpp

  Log Message:
  -----------
  fixup! Add substitution for /Oy-/-fno-omit-frame-pointer


  Commit: 18e537adc6d78d660c8e6bd67f342892ae1f9892
      https://github.com/llvm/llvm-project/commit/18e537adc6d78d660c8e6bd67f342892ae1f9892
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/ill.cpp

  Log Message:
  -----------
  fixup! add a comment clarifying arch support in ill.cpp


  Commit: b6206ef575114a220134b53cc08c4eac8eba56db
      https://github.com/llvm/llvm-project/commit/b6206ef575114a220134b53cc08c4eac8eba56db
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/defines.h

  Log Message:
  -----------
  Use an include guard instead of #pragma once

In asan/TestCases/defines.h


  Commit: cd17d5d3b52f155eb5539c9df3a133815fa95a2f
      https://github.com/llvm/llvm-project/commit/cd17d5d3b52f155eb5539c9df3a133815fa95a2f
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/debug_locate.cpp

  Log Message:
  -----------
  Move UNSUPPORTED line to below opening comment


  Commit: 58cd31460e810d9e1286e6879b574d983f670b3e
      https://github.com/llvm/llvm-project/commit/58cd31460e810d9e1286e6879b574d983f670b3e
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/coverage-basic.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/Windows/illegal_instruction.cpp
    M compiler-rt/test/asan/TestCases/Windows/sse_misalignment.cpp
    M compiler-rt/test/asan/TestCases/Windows/stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/alloca_big_alignment.cpp
    M compiler-rt/test/asan/TestCases/alloca_instruments_all_paddings.cpp
    M compiler-rt/test/asan/TestCases/alloca_loop_unpoisoning.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_partial.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_right.cpp
    M compiler-rt/test/asan/TestCases/alloca_safe_access.cpp
    M compiler-rt/test/asan/TestCases/alloca_underflow_left.cpp
    M compiler-rt/test/asan/TestCases/alloca_vla_interact.cpp
    M compiler-rt/test/asan/TestCases/coverage-trace-pc.cpp
    M compiler-rt/test/asan/TestCases/debug_locate.cpp
    M compiler-rt/test/asan/TestCases/default_ignorelist.cpp
    M compiler-rt/test/asan/TestCases/global-location-nodebug.cpp
    M compiler-rt/test/asan/TestCases/global-underflow.cpp
    M compiler-rt/test/asan/TestCases/halt_on_error-1.c
    M compiler-rt/test/asan/TestCases/ignorelist.cpp
    M compiler-rt/test/asan/TestCases/inline.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs-compare-errors.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs-subtract-errors.cpp
    M compiler-rt/test/asan/TestCases/invalid-pointer-pairs.cpp
    M compiler-rt/test/asan/TestCases/pass-struct-byval.cpp
    M compiler-rt/test/asan/TestCases/speculative_load.cpp
    M compiler-rt/test/asan/TestCases/stack-buffer-overflow-with-position.cpp
    M compiler-rt/test/asan/TestCases/stack-oob-frames.cpp
    M compiler-rt/test/asan/TestCases/throw_call_test.cpp
    M compiler-rt/test/asan/TestCases/use-after-scope-inlined.cpp
    M compiler-rt/test/asan/TestCases/vla_chrome_testcase.cpp
    M compiler-rt/test/asan/TestCases/vla_condition_overflow.cpp
    M compiler-rt/test/asan/TestCases/vla_loop_overfow.cpp

  Log Message:
  -----------
  MSVC -> msvc


  Commit: 7b19c923b369afa281d6b3a5ec9fadf2291fe9cc
      https://github.com/llvm/llvm-project/commit/7b19c923b369afa281d6b3a5ec9fadf2291fe9cc
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_stack_use_after_return.cpp
    M compiler-rt/test/asan/TestCases/alloca_instruments_all_paddings.cpp
    M compiler-rt/test/asan/TestCases/alloca_loop_unpoisoning.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_partial.cpp
    M compiler-rt/test/asan/TestCases/alloca_overflow_right.cpp
    M compiler-rt/test/asan/TestCases/alloca_safe_access.cpp
    M compiler-rt/test/asan/TestCases/alloca_underflow_left.cpp
    M compiler-rt/test/asan/TestCases/alloca_vla_interact.cpp
    M compiler-rt/test/asan/TestCases/speculative_load.cpp
    M compiler-rt/test/asan/TestCases/stack-oob-frames.cpp
    M compiler-rt/test/asan/TestCases/throw_call_test.cpp
    M compiler-rt/test/asan/TestCases/vla_chrome_testcase.cpp
    M compiler-rt/test/asan/TestCases/vla_condition_overflow.cpp
    M compiler-rt/test/asan/TestCases/vla_loop_overfow.cpp

  Log Message:
  -----------
  say why things are unsupported on MSVC


  Commit: cf22f1cfc171c4661945d14878564995c57fafdf
      https://github.com/llvm/llvm-project/commit/cf22f1cfc171c4661945d14878564995c57fafdf
  Author: Charlie Barto <barto.charlie at gmail.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/inline.cpp

  Log Message:
  -----------
  reword comment in asan/TestCases/inline.cpp


  Commit: 6dfde42342306b513e7724a5441d6cd383444f79
      https://github.com/llvm/llvm-project/commit/6dfde42342306b513e7724a5441d6cd383444f79
  Author: Charlie Barto <chbarto at microsoft.com>
  Date:   2025-01-27 (Mon, 27 Jan 2025)

  Changed paths:
    M compiler-rt/test/asan/TestCases/alloca_instruments_all_paddings.cpp

  Log Message:
  -----------
  clang-format comment


Compare: https://github.com/llvm/llvm-project/compare/9f133b43d7bd%5E...6dfde4234230

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list