[all-commits] [llvm/llvm-project] 93b90a: [ReachingDefAnalysis] Fix management of MBBFrameOb...

[Michael Maitland via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 93b90a532d0ca5a95c226e3d0b37444ef692d3da
      https://github.com/llvm/llvm-project/commit/93b90a532d0ca5a95c226e3d0b37444ef692d3da
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2025-02-04 (Tue, 04 Feb 2025)

  Changed paths:
    M llvm/include/llvm/CodeGen/ReachingDefAnalysis.h
    M llvm/lib/CodeGen/ReachingDefAnalysis.cpp
    M llvm/test/CodeGen/RISCV/rda-stack.mir

  Log Message:
  -----------
  [ReachingDefAnalysis] Fix management of MBBFrameObjsReachingDefs (#124943)

MBBFrameObjsReachingDefs was not being built correctly since we were not
inserting into a reference of Frame2InstrIdx. If there was multiple
stack slot defs in the same basic block, then the bug would occur. This
PR fixes this problem while simplifying the insertion logic.

Additionally, when lookup into MBBFrameObjsReachingDefs was occurring,
there was a chance that there was no entry in the map, in the case that
there was no reaching def. This was causing us to return a default
value, which may or may not have been correct. This patch returns the
correct value now.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications