[all-commits] [llvm/llvm-project] c26bb4: [lldb] correct event when removing all watchpoints...

[Ben Jackson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c26bb4f095120ff4741b6530b6b3c0ac5a7dacad
      https://github.com/llvm/llvm-project/commit/c26bb4f095120ff4741b6530b6b3c0ac5a7dacad
  Author: Ben Jackson <puremourning at users.noreply.github.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M lldb/source/Breakpoint/WatchpointList.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py

  Log Message:
  -----------
  [lldb] correct event when removing all watchpoints (#125312)

LLDB: correct event when removing all watchpoints
    
    Previously we incorrectly checked for a "breakpoint changed" event
    listener removing all watchpoints (e.g. via
SBTarget::DeleteAllWatchpoints()), although we would emit a "watchpoint
    changed" event if there were a listener for 'breakpoint changed'.
    
This meant that we might not emit a "watchpoint changed" event if there
    was a listener for this event.
    
    Correct it to check for the "watchpoint changed" event.


---


Updated regression tests which were also incorrectly peeking for the
wrong event type. The 'remove' action actually triggers 2 events which
the test didn't allow, so I updated it to allow specifically what was
requested.

The test fails (expectedly) at the line following "DeleteAllWatchpoints"
prior to this patch, and passes after.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications