[all-commits] [llvm/llvm-project] 8f025f: [clang] Do not emit template parameter objects as ...

[Owen Anderson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f025f2a93ee7249336115cff31ae12367f1d0d5
      https://github.com/llvm/llvm-project/commit/8f025f2a93ee7249336115cff31ae12367f1d0d5
  Author: Owen Anderson <resistor at mac.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGenCXX/template-param-objects.cpp

  Log Message:
  -----------
  [clang] Do not emit template parameter objects as COMDATs when they have internal linkage. (#125448)

Per the ELF spec, section groups may only contain local symbols if those
symbols are only
referenced from within the section group. [1] In the case of template
parameter objects,
they can be referenced from outside the group when the type of the
object was declared
in an anonymous namespace. In that case, we can't place the object in a
COMDAT. This matches
GCC's linkage behavior on the test input.

[1]:
https://www.sco.com/developers/gabi/latest/ch4.sheader.html#section_groups



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications