[all-commits] [llvm/llvm-project] f99e6d: [lldb][TypeSystemClang] Pass around enum value as ...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f99e6df1415fa825b8329b381a23cd9c58d6edd4
      https://github.com/llvm/llvm-project/commit/f99e6df1415fa825b8329b381a23cd9c58d6edd4
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-02-03 (Mon, 03 Feb 2025)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h

  Log Message:
  -----------
  [lldb][TypeSystemClang] Pass around enum value as uint64_t (#125244)

The `DWARFASTParserClang` reads enum values as `int64_t`s regardless of
the enumerators signedness. Then we pass it to
`AddEnumerationValueToEnumerationType` and only then do we create an
`APSInt` from it. However, there are other places where we read/pass
around the enum value as unsigned. This patch makes sure we consistently
use the same integer type for the enum value and let `APSInt` take care
of signedness. This shouldn't have any observable effect.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications