[all-commits] [llvm/llvm-project] 43b712: [AST] Migrate away from PointerUnion::dyn_cast (NF...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43b7124c5749b3f3276adf1b869e623e163e230e
      https://github.com/llvm/llvm-project/commit/43b7124c5749b3f3276adf1b869e623e163e230e
  Author: Kazu Hirata <kazu at google.com>
  Date:   2025-02-02 (Sun, 02 Feb 2025)

  Changed paths:
    M clang/include/clang/AST/ExprCXX.h

  Log Message:
  -----------
  [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#125379)

Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

This patch migrates the use of PointerUnion::dyn_cast to
dyn_cast_if_present because the non-const variant of
getInitializedFieldInUnion is known to encounter null in
ArrayFillerOrUnionFieldInit.  See:

  commit 563c7c5539f05e7f8cbb42565c1f24466019f38b
  Author: Kazu Hirata <kazu at google.com>
  Date:   Sat Jan 25 14:05:01 2025 -0800

FWIW, I am not aware of any test case in check-clang that triggers
null here.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications