[all-commits] [llvm/llvm-project] b23297: [GlobalISel] Do not run verifier after ResetMachin...

David Green via All-commits all-commits at lists.llvm.org
Fri Jan 31 16:42:55 PST 2025


  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: b23297a7f160ca37102799d1d1b1deb8114f01a4
      https://github.com/llvm/llvm-project/commit/b23297a7f160ca37102799d1d1b1deb8114f01a4
  Author: David Green <david.green at arm.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/TargetPassConfig.cpp
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.mfma.gfx950.ll

  Log Message:
  -----------
  [GlobalISel] Do not run verifier after ResetMachineFunctionPass (#124799)

After we fall back from GlobalISel to SDAG, the verifier gets called,
which calls getReservedRegs which uses SIMachineFunctionInfo::usesAGPRs
which caches the result of UsesAGPRs. Because we have just fallen-back
the function is empty and it incorrectly gets cached to false. This
patch makes sure we don't try to run the verifier whilst the function is
empty.

(cherry picked from commit 66e0498dafbfa7f8fd7deaa88ae62bdf38a12113)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list