[all-commits] [llvm/llvm-project] f14f19: [CFIFixup] Factor logic into helpers and use range...

Daniel Hoekwater via All-commits all-commits at lists.llvm.org
Fri Jan 31 11:45:15 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f14f19738916572322c310e84196134545c15c49
      https://github.com/llvm/llvm-project/commit/f14f19738916572322c310e84196134545c15c49
  Author: Daniel Hoekwater <hoekwater at google.com>
  Date:   2025-01-31 (Fri, 31 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/CFIFixup.cpp

  Log Message:
  -----------
  [CFIFixup] Factor logic into helpers and use range-based loops (NFC) (#125137)

`runOnMachineFunction` is getting long (>100 lines), and the logic
for computing block info and performing block fixup can be abstracted
away.

Reduce nesting in the main block fixup loop and name conditions to
reflect their purpose.

Replace manual usage of iterators with a range-based for loop.

Source:
-
https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
-
https://llvm.org/docs/CodingStandards.html#use-range-based-for-loops-wherever-possible
-
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list