[all-commits] [llvm/llvm-project] 8d3736: [AMDGPU] Only run `AMDGPUPrintfRuntimeBindingPass`...

Shilei Tian via All-commits all-commits at lists.llvm.org
Thu Jan 30 20:24:06 PST 2025


  Branch: refs/heads/users/shiltian/no-printf-handling-in-pre-link
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d3736d87bcf7e7e5935c6f1c72c84ca4f125668
      https://github.com/llvm/llvm-project/commit/8d3736d87bcf7e7e5935c6f1c72c84ca4f125668
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/test/CodeGen/AMDGPU/print-pipeline-passes.ll

  Log Message:
  -----------
  [AMDGPU] Only run `AMDGPUPrintfRuntimeBindingPass` at non-prelink phase

The pass is registered in a pipeline that will run at none LTO, LTO prelink, as
well as LTO postlink phase. It uses the _current_ number of metadata operands as
unique id for printf handling. However, if two TUs both have `printf`, their
unique id will be starting with 1. After they are linked together, the id is no
longer unique anymore. To resolve this issue, the pass should not run at LTO pre
link stage.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list