[all-commits] [llvm/llvm-project] 242aa8: [flang][hlfir] get rid of box when translating sca...

jeanPerier via All-commits all-commits at lists.llvm.org
Thu Jan 30 08:03:42 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 242aa8c743fe4344844753d8faf59744235319df
      https://github.com/llvm/llvm-project/commit/242aa8c743fe4344844753d8faf59744235319df
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M flang/include/flang/Optimizer/Builder/HLFIRTools.h
    M flang/test/HLFIR/assign-codegen.fir

  Log Message:
  -----------
  [flang][hlfir] get rid of box when translating scalars to extented value (#125059)

The code in `translateToExtendedValue(hlfir::Entity)` was not getting
rid of the fir.box for scalars because isSimplyContiguous() returned
false for them.

This created issues downstream because utilities using
fir::ExtendedValue were not implemented to work with intrinsic scalars
fir.box.

fir.box of intrinsic scalars are not very commonly used as hlfir::Entity
but they are allowed and should work where accepted.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list