[all-commits] [llvm/llvm-project] 2e581d: [flang][NFC] make IR generation for ieee_next dete...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e581dc54b8983122528ade578824d70ec42b503
      https://github.com/llvm/llvm-project/commit/2e581dc54b8983122528ade578824d70ec42b503
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-01-30 (Thu, 30 Jan 2025)

  Changed paths:
    M flang/lib/Optimizer/Builder/IntrinsicCall.cpp

  Log Message:
  -----------
  [flang][NFC] make IR generation for ieee_next deterministic (#125055)

C++ function call argument evaluation order is unspecified. When piping
functions that generates IR, this creates indeterminism in the IR
generated by flang (e.g., depend which C++ compiler compiled flang).

While it has interesting fuzzing property for flang (Initially, most of
expression lowering used that pattern for binary operation where Fortran
also does not specify any order, and we did found bugs exposed by some
of the IR version and not the other), it is not ideal for lit tests (I
found this because of a CI failure when not properly adding `-DAG` [in
test updates](https://github.com/llvm/llvm-project/pull/124966)), and
many people also really value bit to bit reproducibility from compilers.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications