[all-commits] [llvm/llvm-project] 609274: Don't use CLANG_VERSION_MAJOR to check that the va...

[Akira Hatanaka via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60927405f5612158ae0419798838be45a1637911
      https://github.com/llvm/llvm-project/commit/60927405f5612158ae0419798838be45a1637911
  Author: Akira Hatanaka <ahatanak at gmail.com>
  Date:   2025-01-28 (Tue, 28 Jan 2025)

  Changed paths:
    M clang/CMakeLists.txt
    M clang/include/clang/Basic/Version.inc.in
    M clang/lib/Frontend/CompilerInvocation.cpp

  Log Message:
  -----------
  Don't use CLANG_VERSION_MAJOR to check that the value passed to -fclang-abi-compat= is valid (#123998)

Use LLVM_VERSION_MAJOR instead as the maximum allowed value. This change
is needed to fix regression tests that fail when vendors set
CLANG_VERSION_MAJOR to a value that is lower than LLVM_VERSION_MAJOR
when building the compiler.

For example, clang/test/CodeGenCXX/mangle-concept.cpp fails with the
following error if -DCLANG_VERSION_MAJOR=17 is passed to cmake:

invalid value '19' in '-fclang-abi-compat=19'



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications