[all-commits] [llvm/llvm-project] 21f04b: Hold a queue of iterator ranges (not operations) i...

Adam Paszke via All-commits all-commits at lists.llvm.org
Sat Jan 25 07:28:43 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 21f04b1458c52ba875a23b58b02cf6b1f8db0661
      https://github.com/llvm/llvm-project/commit/21f04b1458c52ba875a23b58b02cf6b1f8db0661
  Author: Adam Paszke <adam.paszke at gmail.com>
  Date:   2025-01-25 (Sat, 25 Jan 2025)

  Changed paths:
    M mlir/lib/Interfaces/SideEffectInterfaces.cpp

  Log Message:
  -----------
  Hold a queue of iterator ranges (not operations) in wouldOpBeTriviallyDead (#123642)

Ranges let us push the whole blocks onto the queue in constant time. If
one of the first ops in the block is side-effecting we'll be able to
provide the answer quickly. The previous implementation had to walk the
block and queue all the operations only to start traversing them again,
which was a considerable slowdown for compile times of large MLIR
programs in our benchmarks.

---------

Co-authored-by: Jacques Pienaar <jpienaar at google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list