[all-commits] [llvm/llvm-project] 1b4bd4: [BOLT][AArch64] Remove assertions from jump table ...

[Maksim Panchenko via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b4bd4e1a5120c8bb4daa44787a3bc4559b6b3b4
      https://github.com/llvm/llvm-project/commit/1b4bd4e1a5120c8bb4daa44787a3bc4559b6b3b4
  Author: Maksim Panchenko <maks at fb.com>
  Date:   2025-01-24 (Fri, 24 Jan 2025)

  Changed paths:
    M bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp
    A bolt/test/AArch64/jump-table-heuristic-fail.s
    M bolt/test/AArch64/test-indirect-branch.s

  Log Message:
  -----------
  [BOLT][AArch64] Remove assertions from jump table heuristic (#124372)

The code for jump table detection on AArch64 asserts liberally whenever
the input instruction sequence does not match the expected pattern. As a
result, BOLT fails to process binaries with such sequences instead of
ignoring functions with unknown control flow.

Remove asserts in analyzeIndirectBranchFragment() and mark indirect
jumps as instructions with unknown control flow instead.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications