[all-commits] [llvm/llvm-project] 625ee2: DAG: Avoid breaking legal vector_shuffle with mult...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jan 21 09:02:07 PST 2025


  Branch: refs/heads/users/arsenm/dag/avoid-breaking-multi-use-legal-shuffle-after-legalize
  Home:   https://github.com/llvm/llvm-project
  Commit: 625ee25e8a0534ee06e5ad9493831c41b90af1ec
      https://github.com/llvm/llvm-project/commit/625ee25e8a0534ee06e5ad9493831c41b90af1ec
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-21 (Tue, 21 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4f32.v2f32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4f32.v3f32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4f32.v4f32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4i32.v2i32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4i32.v3i32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4i32.v4i32.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4p3.v2p3.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4p3.v3p3.ll
    M llvm/test/CodeGen/AMDGPU/shufflevector.v4p3.v4p3.ll

  Log Message:
  -----------
  DAG: Avoid breaking legal vector_shuffle with multiple uses

Previously this combine would undo AMDGPU's new custom legalization of
wide vector shuffles into 2 element pieces. The comment also
states that this combine is only done before legalization,
but the case with a build_vector source was unconditional.

We probably don't want to do this if the multiple uses are full
scalarization of the vector, but this seems to work well enough.
Scalarizing extracts should have folded out pre-legalize.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list