[all-commits] [llvm/llvm-project] 2d9f40: [OpenMP] Adjust 'printf' handling in the OpenMP ru...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jan 20 19:57:08 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d9f40694324a72c2b7a3d6a9cfcc7ce8069afc1
      https://github.com/llvm/llvm-project/commit/2d9f40694324a72c2b7a3d6a9cfcc7ce8069afc1
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-01-20 (Mon, 20 Jan 2025)

  Changed paths:
    M offload/DeviceRTL/include/Debug.h
    M offload/DeviceRTL/include/LibC.h
    M offload/DeviceRTL/src/Debug.cpp
    M offload/DeviceRTL/src/LibC.cpp
    M offload/DeviceRTL/src/Parallelism.cpp
    M offload/DeviceRTL/src/State.cpp

  Log Message:
  -----------
  [OpenMP] Adjust 'printf' handling in the OpenMP runtime (#123670)

Summary:
We used to avoid a lot of this stuff because we didn't properly handle
variadics in device code. That's been solved for now, so we can just
make an internal printf handler that forwards to the external `vprintf`
function. This is either provided by NVIDIA's SDK or by the GPU libc
implementation.

The main reason for doing this is because it prevents the stupid AMDGPU
printf pass from mangling our beautiful printfs!



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list