[all-commits] [llvm/llvm-project] 14a07e: [mlir][tblgen] Migrate tests to properties for att...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/users/krzysz00/migrate-tests-to-properties
  Home:   https://github.com/llvm/llvm-project
  Commit: 14a07e9e8ae507b879ec0d7a2f01f8f8b029e942
      https://github.com/llvm/llvm-project/commit/14a07e9e8ae507b879ec0d7a2f01f8f8b029e942
  Author: Krzysztof Drewniak <krzysdrewniak at gmail.com>
  Date:   2025-01-19 (Sun, 19 Jan 2025)

  Changed paths:
    M mlir/test/mlir-tblgen/constraint-unique.td
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/test/mlir-tblgen/op-decl-and-defs.td
    M mlir/test/mlir-tblgen/op-format.td
    M mlir/test/mlir-tblgen/op-result.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir][tblgen] Migrate tests to properties for attributes, fix remove*Attr()

The only in-tree user of `bit usePropertiesForAttributes = 0;` was a series
of tests for the output of -gen-op-{decls,defs}. This commit updates those
tests to match the rest of the repository.

In the short term, this is intended to enable testing upcoming updates to
collective builders. In the long term, this is a step in the removal of
usePropertiesForAttributes = 0.

One side effect of these tests updates was the realization that the
autogenerated implementations of removeFooAttr() were not returning
the value of the removed attribute. This issue has been addressed and
the tests have been updated to reflect the change. This is the only
functionality change in this PR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications