[all-commits] [llvm/llvm-project] c1fc82: [HLSL][RootSignature] Implement Lexing of Descript...

[Finn Plummer via All-commits]

  Branch: refs/heads/users/inbelic/pr-122981
  Home:   https://github.com/llvm/llvm-project
  Commit: c1fc823abf07dfb8326b6190672d9881890bbb15
      https://github.com/llvm/llvm-project/commit/c1fc823abf07dfb8326b6190672d9881890bbb15
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    A clang/include/clang/Parse/HLSLRootSignatureTokenKinds.def
    A clang/include/clang/Parse/ParseHLSLRootSignature.h
    M clang/lib/Parse/CMakeLists.txt
    A clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/CMakeLists.txt
    A clang/unittests/Parse/CMakeLists.txt
    A clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  [HLSL][RootSignature] Implement Lexing of DescriptorTables

- Define required tokens to parse a Descriptor Table in TokenKinds.def
- Implements a Lexer to handle all of the defined tokens in
ParseHLSLRootSignature


  Commit: 949b50af4c60eae588595260d9384d01324245e5
      https://github.com/llvm/llvm-project/commit/949b50af4c60eae588595260d9384d01324245e5
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  fix typo when breaking up commits


  Commit: a3286192694fd8599b74690b79f333482289f548
      https://github.com/llvm/llvm-project/commit/a3286192694fd8599b74690b79f333482289f548
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review comments:

- fix typo
- use std::unique_ptr for testing mem management


  Commit: 8e88fa70156ae5a5d3d0103d65ea99028fbfdf0b
      https://github.com/llvm/llvm-project/commit/8e88fa70156ae5a5d3d0103d65ea99028fbfdf0b
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  review comments: fix handling of signed ints

- update Lexer to allow '+' prefix to denote a signed positive integer
- add missing errors when we expect an unsigned int for parameters
- add tests to show lexing of positive signed integer and unsigned
integer


  Commit: a76b907053462405287a2a5b09454765ff1bf73c
      https://github.com/llvm/llvm-project/commit/a76b907053462405287a2a5b09454765ff1bf73c
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M clang/lib/Parse/ParseHLSLRootSignature.cpp

  Log Message:
  -----------
  review comments: use early exit code convention


Compare: https://github.com/llvm/llvm-project/compare/c1fc823abf07%5E...a76b90705346

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications