[all-commits] [llvm/llvm-project] 30e276: [clang][PCH] Don't try to create standalone debug-...

Michael Buch via All-commits all-commits at lists.llvm.org
Fri Jan 17 01:35:24 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 30e276d06d3176f145151cea96ab01af0c3e842a
      https://github.com/llvm/llvm-project/commit/30e276d06d3176f145151cea96ab01af0c3e842a
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M clang/lib/CodeGen/ObjectFilePCHContainerWriter.cpp
    A clang/test/Modules/gmodules-nodebug.cpp

  Log Message:
  -----------
  [clang][PCH] Don't try to create standalone debug-info for types marked nodebug (#123253)

Fixes one of the crashes uncovered by
https://github.com/llvm/llvm-project/pull/118710

`getOrCreateStandaloneType` asserts that a `DIType` was created for the
requested type. If the `Decl` was marked `nodebug`, however, we can't
generate debug-info for it, so we would previously trigger the assert.
For now keep the assertion around and check the `nodebug` at the
callsite.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list