[all-commits] [llvm/llvm-project] f74850: DAG: Avoid forming shufflevector from a single ext...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Jan 16 17:42:15 PST 2025


  Branch: refs/heads/users/arsenm/dag-do-not-form-shuffle-for-single-extract-element
  Home:   https://github.com/llvm/llvm-project
  Commit: f7485059c6ff1623f2195f509932628cfc3c07ad
      https://github.com/llvm/llvm-project/commit/f7485059c6ff1623f2195f509932628cfc3c07ad
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  DAG: Avoid forming shufflevector from a single extract_vector_elt

This avoids regressions in a future AMDGPU commit. Previously we
would have a build_vector (extract_vector_elt x), undef with free
access to the elements bloated into a shuffle of one element + undef,
which has much worse combine support than the extract.

Alternatively could check aggressivelyPreferBuildVectorSources, but
I'm not sure it's really different than isExtractVecEltCheap.


  Commit: a4823b0ea585d7a96e25870b4589b4086da4f6d8
      https://github.com/llvm/llvm-project/commit/a4823b0ea585d7a96e25870b4589b4086da4f6d8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  Check hasOneUse on the source vector. This gives up some of the x86 improvements


  Commit: e845f03322548ff35a61f4e9033e0de7de22860f
      https://github.com/llvm/llvm-project/commit/e845f03322548ff35a61f4e9033e0de7de22860f
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Count the number of extract uses


  Commit: 7cd9367b4f9a23c7603fed68d3c5f4f085561eaa
      https://github.com/llvm/llvm-project/commit/7cd9367b4f9a23c7603fed68d3c5f4f085561eaa
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Avoid arm regressions


  Commit: 0f588c812c2c551cde646963cd926c5047e9a534
      https://github.com/llvm/llvm-project/commit/0f588c812c2c551cde646963cd926c5047e9a534
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  Cleanup and comment


Compare: https://github.com/llvm/llvm-project/compare/047b467cce79...0f588c812c2c

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list