[all-commits] [llvm/llvm-project] f4289c: DAG: Avoid forming shufflevector from a single ext...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/dag-do-not-form-shuffle-for-single-extract-element
  Home:   https://github.com/llvm/llvm-project
  Commit: f4289c561550075c7ff78cfae137d4d48ad369a4
      https://github.com/llvm/llvm-project/commit/f4289c561550075c7ff78cfae137d4d48ad369a4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  DAG: Avoid forming shufflevector from a single extract_vector_elt

This avoids regressions in a future AMDGPU commit. Previously we
would have a build_vector (extract_vector_elt x), undef with free
access to the elements bloated into a shuffle of one element + undef,
which has much worse combine support than the extract.

Alternatively could check aggressivelyPreferBuildVectorSources, but
I'm not sure it's really different than isExtractVecEltCheap.


  Commit: 75c13f736afa3e5cb3b1facac4e0e1a0c9d1cb5d
      https://github.com/llvm/llvm-project/commit/75c13f736afa3e5cb3b1facac4e0e1a0c9d1cb5d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/avx512-build-vector.ll
    M llvm/test/CodeGen/X86/sse-align-12.ll

  Log Message:
  -----------
  Check hasOneUse on the source vector. This gives up some of the x86 improvements


  Commit: 5a80ae9083e669a2a4a8663be89d98c495f58e6c
      https://github.com/llvm/llvm-project/commit/5a80ae9083e669a2a4a8663be89d98c495f58e6c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/insertelement-duplicates.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Count the number of extract uses


  Commit: e4bbce87c3abb13b40f4eac19014750c9c3a5d2a
      https://github.com/llvm/llvm-project/commit/e4bbce87c3abb13b40f4eac19014750c9c3a5d2a
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/any_extend_vector_inreg_of_broadcast_from_memory.ll
    M llvm/test/CodeGen/X86/buildvec-extract.ll
    M llvm/test/CodeGen/X86/movmsk-bittest.ll
    M llvm/test/CodeGen/X86/split-extend-vector-inreg.ll
    M llvm/test/CodeGen/X86/sse41.ll
    M llvm/test/CodeGen/X86/vec_extract-avx.ll
    M llvm/test/CodeGen/X86/vector-interleaved-store-i32-stride-5.ll
    M llvm/test/CodeGen/X86/vector-narrow-binop.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast.ll
    M llvm/test/CodeGen/X86/zero_extend_vector_inreg_of_broadcast_from_memory.ll

  Log Message:
  -----------
  Avoid arm regressions


  Commit: 047b467cce793fb89c43eb5f90db09d42b192fe3
      https://github.com/llvm/llvm-project/commit/047b467cce793fb89c43eb5f90db09d42b192fe3
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-01-17 (Fri, 17 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  Cleanup and comment


Compare: https://github.com/llvm/llvm-project/compare/3a4b2226a1bf...047b467cce79

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications