[all-commits] [llvm/llvm-project] 3173a4: [llvm-exegesis] Remove implicit conversions of MCR...

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Jan 16 12:00:13 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3173a4fc3aca3b8b21e9064cc38383be3539b3a4
      https://github.com/llvm/llvm-project/commit/3173a4fc3aca3b8b21e9064cc38383be3539b3a4
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2025-01-16 (Thu, 16 Jan 2025)

  Changed paths:
    M llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp

  Log Message:
  -----------
  [llvm-exegesis] Remove implicit conversions of MCRegister to unsigned. NFC (#123223)

-Use MCRegister::id() for BitVector index.
-Replace std::unordered_set<unsigned> with std::set<MCRegister.
There are other std::sets for Register. None for MCRegister before this.
 I'm assuming we can have operator<(MCRegister, MCRegister). This avoids
 needing to add std::hash<MCRegister>.
-Use MCRegister::isValid() to avoid comparing to 0.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list