[all-commits] [llvm/llvm-project] ac2165: [coff] Don't try to write the obj if the assembler...

Daniel Paoliello via All-commits all-commits at lists.llvm.org
Wed Jan 15 09:27:34 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ac2165fe7bb4626c85a9c8938dbe2448220217a5
      https://github.com/llvm/llvm-project/commit/ac2165fe7bb4626c85a9c8938dbe2448220217a5
  Author: Daniel Paoliello <danpao at microsoft.com>
  Date:   2025-01-15 (Wed, 15 Jan 2025)

  Changed paths:
    M llvm/lib/MC/WinCOFFObjectWriter.cpp

  Log Message:
  -----------
  [coff] Don't try to write the obj if the assembler has errors (#123007)

The ASAN and MSAN tests have been failing after #122777 because some
fields are now set in `executePostLayoutBinding` which is skipped by the
assembler if it had errors but read in `writeObject`

Since the compilation has failed anyway, skip `writeObject` if the
assembler had errors.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list