[all-commits] [llvm/llvm-project] e7eac3: [OffloadBundler] Rework the ctor of `OffloadTarget...

[Shilei Tian via All-commits]

  Branch: refs/heads/users/shiltian/rework-offloadtargetinfo-ctor
  Home:   https://github.com/llvm/llvm-project
  Commit: e7eac39e7fd0516069edbc1b0b62bf8eced359df
      https://github.com/llvm/llvm-project/commit/e7eac39e7fd0516069edbc1b0b62bf8eced359df
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M clang/docs/ClangOffloadBundler.rst
    M clang/lib/Driver/OffloadBundler.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/lib/Driver/ToolChains/HIPUtility.cpp
    M clang/test/Driver/clang-offload-bundler-asserts-on.c
    M clang/test/Driver/clang-offload-bundler-standardize.c
    M clang/test/Driver/clang-offload-bundler-zlib.c
    M clang/test/Driver/clang-offload-bundler-zstd.c
    M clang/test/Driver/clang-offload-bundler.c
    M clang/test/Driver/hip-link-bc-to-bc.hip
    M clang/test/Driver/hip-link-bundle-archive.hip
    M clang/test/Driver/hip-offload-compress-zstd.hip
    M clang/test/Driver/hip-rdc-device-only.hip
    M clang/test/Driver/hip-toolchain-rdc-separate.hip
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support generic target

The current parsing of target string assumes to be in a form of
`kind-triple-targetid:feature`, such as
`hipv4-amdgcn-amd-amdhsa-gfx1030:+xnack`. Specifically, the target id does not
contain any `-`, which is not the case for generic target. Also, a generic
target may contain one or more `-`, such as `gfx10-3-generic` and
`gfx12-generic`. As a result, we can no longer depend on `rstrip` to get things
work right. This patch reworks the logic to parse the target string to make it
more robust, as well as supporting generic target.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications