[all-commits] [llvm/llvm-project] 61c9f9: [RISCV] Don't create BuildPairF64 or SplitF64 node...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Jan 13 02:54:43 PST 2025


  Branch: refs/heads/release/19.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 61c9f970b88710c8292cc32b92c1db723fcfff22
      https://github.com/llvm/llvm-project/commit/61c9f970b88710c8292cc32b92c1db723fcfff22
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2025-01-13 (Mon, 13 Jan 2025)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    A llvm/test/CodeGen/RISCV/rvv/rv32-zve-bitcast-crash.ll

  Log Message:
  -----------
  [RISCV] Don't create BuildPairF64 or SplitF64 nodes without D or Zdinx. (#116159)

The fix in ReplaceNodeResults is the only one really required for the
known crash.

I couldn't hit the case in LowerOperation because that requires (f64
(bitcast i64)), but the result type is softened before the input so we
don't get a chance to legalize the input.

The change to the setOperationAction call was an observation that a
i64<->vector cast should not be custom legalized on RV32. The custom
code already calls isTypeLegal on the scalar type.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list