[all-commits] [llvm/llvm-project] 43fdd6: [memprof] Migrate away from PointerUnion::is (NFC)...

[Kazu Hirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43fdd6e81d8ea42d1de8fd96fe45957dee54cb32
      https://github.com/llvm/llvm-project/commit/43fdd6e81d8ea42d1de8fd96fe45957dee54cb32
  Author: Kazu Hirata <kazu at google.com>
  Date:   2025-01-12 (Sun, 12 Jan 2025)

  Changed paths:
    M llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp

  Log Message:
  -----------
  [memprof] Migrate away from PointerUnion::is (NFC) (#122622)

Note that PointerUnion::is have been soft deprecated in
PointerUnion.h:

  // FIXME: Replace the uses of is(), get() and dyn_cast() with
  //        isa<T>, cast<T> and the llvm::dyn_cast<T>

In this patch, I'm calling call().getBase() for an instance of
PointerUnion.  call() alone would return an instance of IndexCall,
which wraps PointerUnion.  Note that isa<> cannot directly accept an
instance of IndexCall, at least without defining CastInfo.

I'm not touching PointerUnion::dyn_cast for now because it's a bit
complicated; we could blindly migrate it to dyn_cast_if_present, but
we should probably use dyn_cast when the operand is known to be
non-null.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications