[all-commits] [llvm/llvm-project] 642254: [mlir][LLVM] Fix conversion of non-standard MLIR f...

Matthias Springer via All-commits all-commits at lists.llvm.org
Sun Jan 12 06:17:33 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6422546e996c769dda39a681da090fe28870a376
      https://github.com/llvm/llvm-project/commit/6422546e996c769dda39a681da090fe28870a376
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-01-12 (Sun, 12 Jan 2025)

  Changed paths:
    M mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp
    M mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir
    M mlir/test/Conversion/FuncToLLVM/func-to-llvm.mlir

  Log Message:
  -----------
  [mlir][LLVM] Fix conversion of non-standard MLIR float types (#122634)

Certain non-standard float types were directly passed through in the
LLVM type converter, resulting in invalid IR or failed assertions:

```
mlir-opt: mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp:638: FailureOr<Type> mlir::LLVMTypeConverter::convertVectorType(VectorType) const: Assertion `LLVM::isCompatibleVectorType(vectorType) && "expected vector type compatible with the LLVM dialect"' failed.
```

The LLVM type converter should not define invalid type conversion rules
for such types. If there is no type conversion rule, conversion patterns
will not apply to ops with such operand types.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list