[all-commits] [llvm/llvm-project] 3fbc34: [WebAssembly] Refactor Wasm EH/SjLj error checking...

Heejin Ahn via All-commits all-commits at lists.llvm.org
Fri Jan 10 13:06:19 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3fbc344b49800bb0f70fd5af46c0a47f6d55bbd1
      https://github.com/llvm/llvm-project/commit/3fbc344b49800bb0f70fd5af46c0a47f6d55bbd1
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M clang/lib/Driver/ToolChains/WebAssembly.cpp
    M clang/test/Driver/wasm-toolchain.c

  Log Message:
  -----------
  [WebAssembly] Refactor Wasm EH/SjLj error checking (#122466)

There were many overlaps between error checking and feature enabling
routines for Wasm EH and Wasm SjLj. This tries to factor out those
common routines in separate lambda functions.

This is not NFC because this ends up disallowing a few new combinations
(e.g. `-fwasm-exceptions` and `-emscripten-cxx-exceptions-allowed`), and
also deletes `-mllvm` from the error messages to share the same lambda
function between options with `-mllvm` and those without it.

This adds a few more tests but does not try to cover every single
possible disallowed combination.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list