[all-commits] [llvm/llvm-project] e2449f: [SelectionDAG] Use SDNode::op_iterator instead of ...

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Jan 9 09:10:18 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e2449f1bceeefd4a603cae024a7a1db763df6834
      https://github.com/llvm/llvm-project/commit/e2449f1bceeefd4a603cae024a7a1db763df6834
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2025-01-09 (Thu, 09 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

  Log Message:
  -----------
  [SelectionDAG] Use SDNode::op_iterator instead of SDNodeIterator. NFC (#122147)

I think SDNodeIterator primarily exists because GraphTraits requires an
iterator that dereferences to SDNode*. op_iterator dereferences to
SDUse* which is implicitly convertible to SDValue.

This piece of code can use SDValue instead of SDNode* so we should
prefer to use the the more common op_iterator.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list