[all-commits] [llvm/llvm-project] fce031: [LLVM][DWARF] Create debug names entry for non-tu ...

[Alexander Yermolovich via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fce0314c384f72cacbfcce148c9d110687c78261
      https://github.com/llvm/llvm-project/commit/fce0314c384f72cacbfcce148c9d110687c78261
  Author: Alexander Yermolovich <43973793+ayermolo at users.noreply.github.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h
    A llvm/test/DebugInfo/X86/dwarf5-debug-names-addr-tu-to-non-tu.ll

  Log Message:
  -----------
  [LLVM][DWARF] Create debug names entry for non-tu top level DIE (#121856)

When creating a Type Unit (TU), LLVM attempts to do so optimistically.
However, if this fails, it discards the TU state and creates the TU
within the Compilation Unit (CU). In such cases, an entry for the
top-level DIE is not created in the debug names table.
This can cause issues when running llvm-dwarfdump --debug-names
--verify, as the missing entry will result in verification failure.
To address this issue, this patch adds a call to the
updateAcceleratorTables when TU creation fails. This ensures that the
debug names table is updated correctly, even in cases where TU creation
fails.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications