[all-commits] [llvm/llvm-project] 56936e: Fixing FindUnusedPort method tcp_socket object cre...

[Sad Al Abdullah via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 56936ec63dcc03f64c129ee45716431e56e5d3d1
      https://github.com/llvm/llvm-project/commit/56936ec63dcc03f64c129ee45716431e56e5d3d1
  Author: Sad Al Abdullah <siam9090 at gmail.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

  Log Message:
  -----------
  Fixing FindUnusedPort method tcp_socket object creation with proper constructor parameter (#121879)

### Issue: 
Currently lldb `platform connect unix-connect://localhost:43045/` is
failing and showing "Failed to connect port" error message.
 

![IMG_2492](https://github.com/user-attachments/assets/816931e2-8b06-427e-b11a-39b813094e36)


###  Cause:
TCPSocket(bool should_close, bool child_processes_inherit) constructor
was removed in commit
[c1dff71](https://github.com/llvm/llvm-project/commit/c1dff7152592f1beee9059ee8e2cb3cc68baea4d#diff-91817651b505a466ea94ddc44eca856f62073e03b05d0d0d2f4a55dcfea0002eL20).
However, the tcp_socket object creation still passes the deleted
constructor parameters, which causes the invocation of the wrong
constructor. As a result, the `FindUnusedPort` method is unable to
resolve the local port and always returns 0.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications