[all-commits] [llvm/llvm-project] 5f7568: [mlir][Transforms] Fix mapping in `findOrBuildRepl...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f7568a32c5572e10c8818192a985d7278a261e2
      https://github.com/llvm/llvm-project/commit/5f7568a32c5572e10c8818192a985d7278a261e2
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Fix mapping in `findOrBuildReplacementValue` (#121644)

Fixes two minor issues in `findOrBuildReplacementValue`:
* Remove a redundant `mapping.map`.
* Map `repl` instead of `value`. We used to overwrite an existing
mapping, which could introduce extra materializations.

Note: We generally do not want to overwrite mappings, but create a chain
of mappings. There are still a few more places, where a mapping is
overwritten. Once those are fixed, I will put an assertion into
`ConversionValueMapping::map`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications