[all-commits] [llvm/llvm-project] 1d1554: [libc++] Remove abandoned __append declaration in ...

[Peng Liu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d155412547b0073ecbbdccb02acc31273f3be49
      https://github.com/llvm/llvm-project/commit/1d155412547b0073ecbbdccb02acc31273f3be49
  Author: Peng Liu <winner245 at hotmail.com>
  Date:   2025-01-05 (Sun, 05 Jan 2025)

  Changed paths:
    M libcxx/include/__vector/vector_bool.h

  Log Message:
  -----------
  [libc++] Remove abandoned __append declaration in vector<bool> (#121673)

The `vector<bool>` implementation in libcxx contains a declaration of a
private `__append` function, which is neither defined nor used anywhere
in the codebase. This PR aims to remove this abandoned declaration, as
its presence is misleading and could lead to confusion during future
maintenance.

I have no idea why we have a declaration without a definition. My guess
is that the declaration might be inherited from the implementation of
`vector<T>`, where `__append` is both necessary and properly defined.
The declaration may have been inadvertently copied from `vector<T>` to
`vector<bool>` and subsequently abandoned, as `vector<bool>` never needs
it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications