[all-commits] [llvm/llvm-project] 110260: [mlir][Transforms] Fix mapping in `findOrBuildRepl...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/fix_mapping_1
  Home:   https://github.com/llvm/llvm-project
  Commit: 11026039f7ce600ff04fcf2e54a84035f4484678
      https://github.com/llvm/llvm-project/commit/11026039f7ce600ff04fcf2e54a84035f4484678
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2025-01-04 (Sat, 04 Jan 2025)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Fix mapping in `findOrBuildReplacementValue`

Fixes two minor issues in `findOrBuildReplacementValue`:
* Remove a redundant `mapping.map`.
* Map `repl` instead of `value`. We used to overwrite an existing mapping, which may introduce extra materializations.

Note: We generally do not want to overwrite mappings, but create a chain of mappings. There are still a few more places, where a mapping is overwritten. Once those are fixed, I will put an assertion into `ConversionValueMapping::map`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications