[all-commits] [llvm/llvm-project] 78f044: [mlir][python] declare `_PyClassMethod_New` undefi...

Maksim Levental via All-commits all-commits at lists.llvm.org
Fri Jan 3 13:52:29 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 78f04477d658ae3de3cd416947c5bac65262a9ec
      https://github.com/llvm/llvm-project/commit/78f04477d658ae3de3cd416947c5bac65262a9ec
  Author: Maksim Levental <maksim.levental at gmail.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M mlir/cmake/modules/AddMLIRPython.cmake

  Log Message:
  -----------
  [mlir][python] declare `_PyClassMethod_New` undefined at link time (#121597)

`NanobindAdaptors.h` uses `PyClassMethod_New` to build `pure_subclass`es
but nanobind doesn't declare this API as undefined in its linker flags.
So we need to declare it as such for downstream users that do not do
something like `-undefined dynamic_lookup`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list