[all-commits] [llvm/llvm-project] 5cf138: [llvm][JITLink][LoongArch] Fix bit extraction on 3...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5cf138cfbaa8040100fed1d0d5e0a189759b24ab
      https://github.com/llvm/llvm-project/commit/5cf138cfbaa8040100fed1d0d5e0a189759b24ab
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/JITLink/loongarch.h

  Log Message:
  -----------
  [llvm][JITLink][LoongArch] Fix bit extraction on 32 bit platforms

This shifted `1UL` to make the mask. On 32 bit Linux UL is 32 bit,
so if Hi+1 was >= 32 then you'd get the wrong result here.

The other version of this uses 1ULL, but using the uint64_t typename
here saves someone going to check what ULL means on different platforms.

This fixes test failures seen on Linaro's 32 bit bots:
https://lab.llvm.org/buildbot/#/builders/39/builds/3700
https://lab.llvm.org/buildbot/#/builders/122/builds/781

Though I cannot say exactly why this fixes them. Does not seem
like the new code was triggering this problem, but somehow it
must be.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications