[all-commits] [llvm/llvm-project] 9df375: [lld][WebAssembly] Fix non-pie dynamic-linking exe...

YAMAMOTO Takashi via All-commits all-commits at lists.llvm.org
Thu Jan 2 18:53:42 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9df375e5eae726c5a90ada70f9535a5e22e90214
      https://github.com/llvm/llvm-project/commit/9df375e5eae726c5a90ada70f9535a5e22e90214
  Author: YAMAMOTO Takashi <yamamoto at midokura.com>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    A lld/test/wasm/dylink-non-pie.s
    M lld/wasm/Relocations.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Fix non-pie dynamic-linking executable (#108146)

The commit 22b7b84860d39da71964c9b329937f2ee1d875ba
made the symbols provided by shared libraries "defined",
and thus effectively made it impossible to generate non-pie
dynamically linked executables using
--unresolved-symbols=import-dynamic.

This commit, based on https://github.com/llvm/llvm-project/pull/109249,
fixes it by checking sym->isShared() explictly.
(as a bonus, you don't need to rely on
--unresolved-symbols=import-dynamic
anymore.)

Fixes https://github.com/llvm/llvm-project/issues/107387



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list