[all-commits] [llvm/llvm-project] 699dea: [DirectX] Add getpointer docs to DXILResources.rst

Justin Bogner via All-commits all-commits at lists.llvm.org
Mon Dec 23 15:32:39 PST 2024


  Branch: refs/heads/users/bogner/120778+120779
  Home:   https://github.com/llvm/llvm-project
  Commit: 699dea0e3ea68c584aff99d7bd5ff913001457c8
      https://github.com/llvm/llvm-project/commit/699dea0e3ea68c584aff99d7bd5ff913001457c8
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M llvm/docs/DirectX/DXILResources.rst

  Log Message:
  -----------
  [DirectX] Add getpointer docs to DXILResources.rst


  Commit: 07eb18031071dc192ffe8089fb631bfda9ed557d
      https://github.com/llvm/llvm-project/commit/07eb18031071dc192ffe8089fb631bfda9ed557d
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M llvm/docs/DirectX/DXILResources.rst
    M llvm/include/llvm/IR/IntrinsicsDirectX.td
    M llvm/lib/Target/DirectX/DXILOpLowering.cpp
    M llvm/lib/Target/DirectX/DXILResourceAccess.cpp
    M llvm/test/CodeGen/DirectX/BufferLoad.ll
    M llvm/test/CodeGen/DirectX/ResourceAccess/load_typedbuffer.ll
    M llvm/test/CodeGen/DirectX/ResourceAccess/store_typedbuffer.ll
    M llvm/test/CodeGen/DirectX/ResourceGlobalElimination.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/typed-uav-load-additional-formats.ll

  Log Message:
  -----------
  [DirectX] Remove the "checked" variants of `dx.resource.load`

We'd introduced separate versions of `llvm.dx.resource.load` with a
struct return to handle the CheckAccessFullyMapped case without making
the IR for the common case unnecessarily complicated. However, at this
point the common case is really `resource.getpointer`, so the ergonomics
of a simplified version of `load` don't actually gain us as much as the
cost of having multiple opcodes.

Drop the `dx.resource.loadchecked` functions and have `dx.resource.load`
consistently return `{element_type, i1}`.


Compare: https://github.com/llvm/llvm-project/compare/699dea0e3ea6%5E...07eb18031071

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list